-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(managers/custom): generic manager for json files #32784
base: main
Are you sure you want to change the base?
feat(managers/custom): generic manager for json files #32784
Conversation
…Singh/renovate into feat/generic-manager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely want to see an example of this working on a real repo
Test run on renovate repo, targeting the |
Tried to make the matching logic in |
The JSONata manager is unique in Renovate in because: | ||
|
||
- It is configurable via [JSONata](https://jsonata.org/) queries | ||
- It can extract any `datasource` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?? wha does it mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied regex maanger. Possbly trying to convey that the manager can be used with any datasource or will lookup releases from all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting for the refactor PR to be merged and this PR update onto
Changes
jsonata
queries to extract the deps info from a package file. Details are similar to regex manager implementation, except that we do not need to explicitly handle the recursive matching as that is already handled by thejsonata
query language.Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: