feat(manager/helmfile): allow forward slashes in OCI chart names #33162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzaxak
force-pushed
the
helmfile-oci-folders
branch
2 times, most recently
from
bc18120 to
66bf03d
Compare
Issue was described in [discussion][1]. The helmfile manager now properly handles OCI chart names that contain forward slashes. Previously, the validation would reject chart names with slashes even for OCI repositories. This change modifies the isValidChartName function to use different validation rules for OCI vs non-OCI charts. Added test coverage to verify the new behavior works correctly. [1]: renovatebot#26207
kuzaxak
force-pushed
the
helmfile-oci-folders
branch
from
66bf03d to
6040cd7
Compare
rarkins
previously approved these changes
Dec 17, 2024
|
@rarkins, my bad; I forgot to check the TS compilation. I checked and fixed both issues. Tests are running too. |
viceice
reviewed
Dec 17, 2024
|
@viceice Hey, I've fixed the tests and linter problems. Could you review it once more? I see that the build passes. Thank you! |
|
@rarkins I think after my last push a new review is required to pass check and merge PR. |
rarkins
approved these changes
Dec 22, 2024
viceice
approved these changes
Dec 22, 2024
|
🎉 This PR is included in version 39.81.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The helmfile manager now properly handles OCI chart names that contain forward slashes. Previously, the validation would reject chart names with slashes even for OCI repositories. This change modifies the isValidChartName function to use different validation rules for OCI vs non-OCI charts.
Added test coverage to verify the new behavior works correctly.
Context
Issue was described in discussion.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: