feat: extract artifactory timestamps from columns #33187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Arc676
changed the title
rarkins
reviewed
Dec 18, 2024
lib/modules/datasource/artifactory/__fixtures__/releases-as-files.html
Outdated
Show resolved
Hide resolved
Arc676
force-pushed
the
artifactory-timestamps
branch
from
dfda1cd to
903b284
Compare
viceice
reviewed
Dec 20, 2024
rarkins
reviewed
Dec 20, 2024
| @@ -114,6 +115,8 @@ export class ArtifactoryDatasource extends Datasource { | |||
| } | |||
|
|
|||
| private static parseReleaseTimestamp(rawText: string): string { | |||
| return rawText.trim().replace(regEx(/ ?-$/), '') + 'Z'; | |||
| return ( | |||
| rawText.split(regEx(/\s{2,}/)).filter(e => DateTime.fromFormat(e, "dd-LLL-yyyy HH:mm").isValid)[0] + 'Z' | |||
There was a problem hiding this comment.
@viceice I would have preferred not to make this datetime refactor as part of this fix
Arc676
force-pushed
the
artifactory-timestamps
branch
from
2e8ac09 to
b81015b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The assumptions for the Artifactory datasource are tweaked to allow for additional information to be provided in the table. Instead of assuming that only a timestamp is present, assume that there are columns (separated by at least 2 spaces) and that only one of them contains a valid date.
The unit tests for the Artifactory datasource are adjusted to test this new change.
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: