Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diagnostic configuration #247

Merged
merged 6 commits into from
Jul 14, 2024
Merged

Improve diagnostic configuration #247

merged 6 commits into from
Jul 14, 2024

Conversation

LuqueDaniel
Copy link
Member

@LuqueDaniel LuqueDaniel commented Feb 11, 2023 •
edited by duckdoom4
Loading

Changes

  • Group all diagnostic settings in renpy.diagnostics.
  • Move diagnostics set up to diagnostics module.

TODO

@LuqueDaniel LuqueDaniel added bug Something isn't working enhancement Small improvements topic:diagnostics labels Feb 11, 2023
@LuqueDaniel LuqueDaniel added this to the 2.2.0 milestone Feb 11, 2023
duckdoom4
duckdoom4 reviewed Feb 23, 2023
View reviewed changes
Copy link
Collaborator

@duckdoom4 duckdoom4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Nice work :)

src/diagnostics.ts Show resolved Hide resolved
@LuqueDaniel
Adds the option diagnosticMode.
d73f761 
This option allows to choose whether to diagnose the open files
or all files in the workspace.

Fixed #149
@LuqueDaniel
Copy link
Member Author

I think it's a good time to refactor the diagnostics.ts module and use objects.

duckdoom4
duckdoom4 previously approved these changes Mar 15, 2023
View reviewed changes
@LuqueDaniel LuqueDaniel modified the milestones: 2.2.0, 2.4.X Jun 4, 2023
@LuqueDaniel LuqueDaniel marked this pull request as ready for review July 13, 2024 13:50
@LuqueDaniel
Copy link
Member Author

@duckdoom4 Passes all checks except Format (damn pretier)

@duckdoom4 duckdoom4 merged commit 0aca155 into develop Jul 14, 2024
3 checks passed
@duckdoom4 duckdoom4 deleted the fix-149 branch July 14, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duckdoom4 duckdoom4 duckdoom4 left review comments

Assignees
No one assigned
Labels
bug Something isn't working enhancement Small improvements topic:diagnostics
Projects
None yet
Milestone
2.4.X
Development

Successfully merging this pull request may close these issues.
2 participants
@LuqueDaniel @duckdoom4