Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist auth and refresh tokens #1072

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

kannanvijayan
Copy link

@kannanvijayan kannanvijayan commented Jan 8, 2024

Fixed up everything. The main C++ logic got moved over to RecordReplayService, the auth flow can be triggered from within RecordReplayManager, and open an external browser using RecordReplayService, and the auth.ts code in the web container gets the right tokens and also correctly persists them to prefs.

toshok and others added 5 commits January 3, 2024 11:43
Squashed commit of the following:

commit 994bdc9bd36d870958e6bd8e213c6905a6038dca
Author: Chris Toshok <[email protected]>
Date:   Wed Dec 13 12:52:12 2023 -0800

    remove the include too

commit 3e82c721ce9bc805298538f6c1c3c56eb8a004b0
Author: Chris Toshok <[email protected]>
Date:   Wed Dec 13 12:08:38 2023 -0800

    the big renaming

commit bd81a6c7578e61771240a8fa7b3c7672973f9d68
Author: Chris Toshok <[email protected]>
Date:   Wed Dec 13 10:08:04 2023 -0800

    rename the member fields, and switch to checking if the observer receiver is already bound (saving us that weird extra auth_token_store_ check) in RecordReplayRegisterAuthTokenObserver)

commit 7f8369014d39183acc4efca9220dafcd51912f82
Author: Chris Toshok <[email protected]>
Date:   Fri Dec 8 11:23:30 2023 -0800

    plumb the rest of the devtools messages to the (increasingly misnamed) auth token store
The GH polling we're doing is tying up a buildkite agent, causing everything to wait unnecessarily.  We'll be switching this e2e test run to a different system now that won't block agents.  Let's axe this for now.
For #RUN-2991 (https://linear.app/replay/issue/RUN-2991)

Add Profile pointer to RecordReplayService.
Forward main implementation and API to RecordReplayService.
Register record_replay dictionary in prefs.
@kannanvijayan kannanvijayan force-pushed the kannan/persist-auth-and-refresh-tokens branch from 0057127 to 366623e Compare January 10, 2024 19:52
@kannanvijayan kannanvijayan marked this pull request as ready for review January 10, 2024 21:04
UI code needs access to the user token to pass it down to
recorded render processes to get them to stream the recording.

This exposes it and seems to work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants