-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getByPrototype #472
getByPrototype #472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For cSpell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be renamed to getByPrototype
(singular)
keeping it consistent with |
Props is plural because there are multiple props that you're getting by. There's only one prototype. Plus, |
What? No. Singular is more appropriate here. If you're just getting one prototype with the filter, there is no scenario in which plural makes sense. Use what fits the meaning. |
nope multiple prototypes are used to get the function usually for good measures. it works just like getByProps |
this is how its used edit: you can use without options too just included to show that it works just like getByProps |
❌ Deploy Preview for replugged-docs failed.
|
adds a function to webpack to get function with specified prototype properties.
returns the function itself if not getting raw/all modules.
closes #375
note: i did the testing and it works as of function, idk about types. pls test them <3