Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom titlebar on linux #644

Open
wants to merge 7 commits into
base: v4.9.0
Choose a base branch
from
Open

custom titlebar on linux #644

wants to merge 7 commits into from

Conversation

yofukashino
Copy link
Contributor

No description provided.

@FedeIlLeone FedeIlLeone added enhancement New feature or request semver: minor Requires a minor semver version bump labels Sep 7, 2024
FedeIlLeone
FedeIlLeone requested changes Nov 24, 2024
View reviewed changes
Copy link
Member

@FedeIlLeone FedeIlLeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, tested on Ubuntu 22.04. I'll add the strings for i18n and everything else is ok except for that restart modal.

src/renderer/coremods/settings/pages/General.tsx Outdated Show resolved Hide resolved
@FedeIlLeone FedeIlLeone added this to the v4.9.0 milestone Nov 24, 2024
@FedeIlLeone FedeIlLeone changed the base branch from main to v4.9.0 November 24, 2024 10:00
@FedeIlLeone
Copy link
Member

Works as expected, tested on Ubuntu 22.04. I'll add the strings for i18n and everything else is ok except for that restart modal.

Added strings and changed the restart modal to do a full relaunch.
I also fixed a bug with overlays that added the title bar there. removing an unnecessary plaintext patch fixes this.

PR is ready for v4.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeIlLeone FedeIlLeone FedeIlLeone approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request semver: minor Requires a minor semver version bump
Projects
None yet
Milestone
v4.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yofukashino @FedeIlLeone