-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rc/5.11.0 || Release #128
rc/5.11.0 || Release #128
Conversation
EPMRPP-84831 || Update Gradle build script
…into rc/5.11.0 � Conflicts: � build.gradle
@@ -68,16 +68,16 @@ void removeLogs() { | |||
|
|||
final List<Long> launchIds = getLaunchIds(projectId, lessThanDate); | |||
if (!launchIds.isEmpty()) { | |||
deleteLogsFromElasticsearchByLaunchIdsAndProjectId(launchIds, projectId); | |||
deleteLogsFromSearchEngineByLaunchIdsAndProjectId(launchIds, projectId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'if' child has incorrect indentation level 10, expected level should be 22.
@@ -77,7 +77,7 @@ private void removeLaunches() { | |||
indexerServiceClient.removeFromIndexLessThanLaunchDate(projectId, lessThanDate); | |||
LOGGER.info("Send message for deletion to analyzer for project {}", projectId); | |||
|
|||
deleteLogsFromElasticsearchByLaunchIdsAndProjectId(launchIds, projectId); | |||
deleteLogsFromSearchEngineByLaunchIdsAndProjectId(launchIds, projectId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'if' child has incorrect indentation level 10, expected level should be 22.
|
||
protected final Logger LOGGER = LoggerFactory.getLogger(SimpleElasticSearchClient.class); | ||
protected final Logger LOGGER = LoggerFactory.getLogger(SimpleSearchEngineClient.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abbreviation in name 'LOGGER' must contain no more than '1' consecutive capital letters.
|
||
protected final Logger LOGGER = LoggerFactory.getLogger(SimpleElasticSearchClient.class); | ||
protected final Logger LOGGER = LoggerFactory.getLogger(SimpleSearchEngineClient.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Member name 'LOGGER' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
public SimpleElasticSearchClient(@Value("${rp.elasticsearch.host}") String host, | ||
@Value("${rp.elasticsearch.username:}") String username, | ||
@Value("${rp.elasticsearch.password:}") String password) { | ||
public SimpleSearchEngineClient(@Value("${rp.searchengine.host}") String host, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a Javadoc comment.
Quality Gate passedIssues Measures |
No description provided.