Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc/5.11.0 || Release #128

Closed
wants to merge 7 commits into from
Closed

rc/5.11.0 || Release #128

wants to merge 7 commits into from

Conversation

pbortnik
Copy link
Contributor

@pbortnik pbortnik commented Mar 3, 2024

No description provided.

…into rc/5.11.0

� Conflicts:
�	build.gradle
@@ -68,16 +68,16 @@ void removeLogs() {

final List<Long> launchIds = getLaunchIds(projectId, lessThanDate);
if (!launchIds.isEmpty()) {
deleteLogsFromElasticsearchByLaunchIdsAndProjectId(launchIds, projectId);
deleteLogsFromSearchEngineByLaunchIdsAndProjectId(launchIds, projectId);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' child has incorrect indentation level 10, expected level should be 22.

@@ -77,7 +77,7 @@ private void removeLaunches() {
indexerServiceClient.removeFromIndexLessThanLaunchDate(projectId, lessThanDate);
LOGGER.info("Send message for deletion to analyzer for project {}", projectId);

deleteLogsFromElasticsearchByLaunchIdsAndProjectId(launchIds, projectId);
deleteLogsFromSearchEngineByLaunchIdsAndProjectId(launchIds, projectId);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' child has incorrect indentation level 10, expected level should be 22.


protected final Logger LOGGER = LoggerFactory.getLogger(SimpleElasticSearchClient.class);
protected final Logger LOGGER = LoggerFactory.getLogger(SimpleSearchEngineClient.class);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck> reported by reviewdog 🐶
Abbreviation in name 'LOGGER' must contain no more than '1' consecutive capital letters.


protected final Logger LOGGER = LoggerFactory.getLogger(SimpleElasticSearchClient.class);
protected final Logger LOGGER = LoggerFactory.getLogger(SimpleSearchEngineClient.class);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.naming.MemberNameCheck> reported by reviewdog 🐶
Member name 'LOGGER' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.

public SimpleElasticSearchClient(@Value("${rp.elasticsearch.host}") String host,
@Value("${rp.elasticsearch.username:}") String username,
@Value("${rp.elasticsearch.password:}") String password) {
public SimpleSearchEngineClient(@Value("${rp.searchengine.host}") String host,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> reported by reviewdog 🐶
Missing a Javadoc comment.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pbortnik pbortnik closed this Mar 13, 2024
@pbortnik pbortnik deleted the rc/5.11.0 branch March 13, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants