Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1061] Remove unused dependency #1095

Merged
merged 7 commits into from
Mar 4, 2020
Merged

[#1061] Remove unused dependency #1095

merged 7 commits into from
Mar 4, 2020

Conversation

Tejas2805
Copy link
Contributor

@Tejas2805 Tejas2805 commented Feb 23, 2020 •
edited
Loading

Fixes part of #1061

Netlify build takes a lot of time due to a large number of 
dependencies. 

Let's remove the unused dependencies to reduce the build
time.

@Tejas2805 Tejas2805 mentioned this pull request Feb 23, 2020
Draft
@Tejas2805
Copy link
Contributor Author

Tejas2805 commented Feb 23, 2020 •
edited
Loading

Main focus on #1096

EDIT 1: As discussed in #1096 we will keep it only as a check. Re-opening this PR.

@Tejas2805 Tejas2805 closed this Feb 23, 2020
@Tejas2805 Tejas2805 reopened this Feb 24, 2020
@Tejas2805 Tejas2805 requested a review from fzdy1914 February 24, 2020 17:52
@Tejas2805 Tejas2805 marked this pull request as ready for review February 25, 2020 06:36
@Tejas2805 Tejas2805 changed the title Remove unused dependency [#1061]Remove unused dependency Feb 25, 2020
@Tejas2805 Tejas2805 changed the title [#1061]Remove unused dependency [#1061] Remove unused dependency Feb 25, 2020
@fzdy1914
Copy link
Member

Is there more dependency to remove?

@Tejas2805
Copy link
Contributor Author

This is the only dependency that we can remove. There might be other optimizations in Gradle possible though

@Tejas2805
Copy link
Contributor Author

@fzdy1914 Have checked for other Gradle lint rules. All seem to be okay.

@fzdy1914
Copy link
Member

OK

@Tejas2805 Tejas2805 requested a review from a team February 26, 2020 15:05
@Tejas2805 Tejas2805 closed this Feb 28, 2020
@Tejas2805 Tejas2805 reopened this Feb 28, 2020
@Tejas2805 Tejas2805 requested a review from a team February 28, 2020 14:23
@anubh-v
Copy link
Contributor

anubh-v commented Feb 29, 2020

I just have a question to better understand the gradle build file. Do we know how this dependency was being used in the past? Or was it always unused?

@anubh-v
Copy link
Contributor

anubh-v commented Feb 29, 2020

Based on a search, it seems that this Java Parser library was previously used in the MethodAnalyzer class which was removed in PR 628

@fzdy1914 fzdy1914 merged commit bd70e84 into reposense:master Mar 4, 2020
Tejas2805 added a commit to Tejas2805/RepoSense that referenced this pull request Mar 6, 2020
@Tejas2805
Merge branch 'master' of https://github.com/reposense/RepoSense
05fc559 
* 'master' of https://github.com/reposense/RepoSense:
  [reposense#1047] v_summary: simplify toDisplay user logic (reposense#1051)
  [reposense#658] Modify checkstyle configuration (reposense#1094)
  Add commit message length configuration border (reposense#1048)
  [reposense#1061] build.gradle: remove unused dependency (reposense#1095)
  [reposense#1044] Update date hashes on reset date range (reposense#1068)
@Tejas2805 Tejas2805 deleted the remove-unused-dependency branch March 8, 2020 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anubh-v anubh-v anubh-v approved these changes

@fzdy1914 fzdy1914 fzdy1914 approved these changes

@jamessspanggg jamessspanggg jamessspanggg approved these changes

@eugenepeh eugenepeh eugenepeh approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tejas2805 @fzdy1914 @anubh-v @eugenepeh @jamessspanggg