Enhance bodi exceptions to include name of interface when duplicate registrations attempted #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the Interface being registered when an instance for that interface has already been registered and resolved.
Added committer name to changelog
Code-Grump
reviewed
Nov 10, 2024
Co-authored-by: Paul "Code Grump" Turner <[email protected]>
Co-authored-by: Paul "Code Grump" Turner <[email protected]>
@Code-Grump , thanks for the suggestions! |
Code-Grump
approved these changes
Nov 11, 2024
ajeckmans
reviewed
Nov 12, 2024
Reqnroll/BoDi/ObjectContainer.cs
Outdated
| @@ -364,7 +364,7 @@ public IStrategyRegistration RegisterTypeAs<TType, TInterface>(string name = nul | |||
| public IStrategyRegistration RegisterTypeAs(Type implementationType, Type interfaceType, string name = null) | |||
| { | |||
| if (!IsValidTypeMapping(implementationType, interfaceType)) | |||
| throw new InvalidOperationException("type mapping is not valid"); | |||
| throw new InvalidOperationException($"type mapping is not valid: {implementationType} -> {interfaceType}"); | |||
There was a problem hiding this comment.
This error message is quite technical. Consider rewording it to something like The provided type mapping is not valid. The {implementationType} is not assignable to {interfaceType}
There was a problem hiding this comment.
Agreed. Modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once an interface has been registered and an instance of an object for that registration has been resolved, BoDi does not allow that registration to be altered. The exception message however is vague and does not indicate which Interface registration attempt caused the exception.
🤔 What's changed?
The error messages given to the BoDi exceptions have been enhanced to include type/interface information.
⚡️ What's your motivation?
Ease of diagnosing error situations when enhancing Reqnroll and Plugins.
🏷️ What kind of change is this?
📋 Checklist: