Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic FAQ and Changing Integration Test Framework pages #325

Merged
merged 8 commits into from
Nov 22, 2024

Conversation

melchiork
Copy link
Contributor

🤔 What's changed?

Documentation only changes. Basic FAQ and Changing Integration Test Framework pages.

⚡️ What's your motivation?

Everybody likes to have docs nobody likes to write them.

🏷️ What kind of change is this?

  • 📖 Documentation (improvements without changing code)

♻️ Anything particular you want feedback on?

Should I aim to rewrite SpecFlow FAQ? It does not look very focused.

📋 Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Copy link
Contributor

@clrudolphi clrudolphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to improve Reqnroll!

@melchiork
Copy link
Contributor Author

@clrudolphi Anything else you'd suggest to change or improve?

@clrudolphi
Copy link
Contributor

@clrudolphi Anything else you'd suggest to change or improve?

Please add an entry in the CHANGELOG.md (near the top, follow the template) so that these additions are highlighted in the next release.

Other than the minor items just mentioned, these look good. Please add Gaspar as a reviewer to this PR.
I will mark this PR with my approval, but Gaspar is the one to merge it into Main.

@melchiork
Copy link
Contributor Author

@clrudolphi Anything else you'd suggest to change or improve?

Please add an entry in the CHANGELOG.md (near the top, follow the template) so that these additions are highlighted in the next release.

Other than the minor items just mentioned, these look good. Please add Gaspar as a reviewer to this PR. I will mark this PR with my approval, but Gaspar is the one to merge it into Main.

Sure, @gasparnagy if you could review it would be grand.

Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super, thx!
My only request is to undo the changes in CHANGELOG.md: documentation changes are immediately become publicly available and they are not bound to releases or release versions, so we don't include them in the changelog.

@melchiork
Copy link
Contributor Author

This is super, thx! My only request is to undo the changes in CHANGELOG.md: documentation changes are immediately become publicly available and they are not bound to releases or release versions, so we don't include them in the changelog.

Done.

@melchiork melchiork requested a review from gasparnagy November 21, 2024 17:38
Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@gasparnagy gasparnagy merged commit 8f62fbc into reqnroll:main Nov 22, 2024
5 checks passed
@melchiork melchiork deleted the documentation-improvements-1 branch November 24, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants