-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic FAQ and Changing Integration Test Framework pages #325
Basic FAQ and Changing Integration Test Framework pages #325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to improve Reqnroll!
@clrudolphi Anything else you'd suggest to change or improve? |
Please add an entry in the CHANGELOG.md (near the top, follow the template) so that these additions are highlighted in the next release. Other than the minor items just mentioned, these look good. Please add Gaspar as a reviewer to this PR. |
Sure, @gasparnagy if you could review it would be grand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super, thx!
My only request is to undo the changes in CHANGELOG.md: documentation changes are immediately become publicly available and they are not bound to releases or release versions, so we don't include them in the changelog.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
🤔 What's changed?
Documentation only changes. Basic FAQ and Changing Integration Test Framework pages.
⚡️ What's your motivation?
Everybody likes to have docs nobody likes to write them.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Should I aim to rewrite SpecFlow FAQ? It does not look very focused.
📋 Checklist: