SystemTests: add net9 portability test #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obligaron
reviewed
Nov 17, 2024
Tests/TestProjectGenerator/Reqnroll.TestProjectGenerator/Data/TargetFramework.cs
Outdated
Show resolved
Hide resolved
Tests/TestProjectGenerator/Reqnroll.TestProjectGenerator/TargetFrameworkMonikerStringBuilder.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: obligaron <[email protected]>
obligaron
approved these changes
Nov 18, 2024
|
@chrisbillson Could you please make a dummy push to your branch to see if the tests pass again now as #330 is merged? |
@gasparnagy done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Added a new .net9 system/portability test.
⚡️ What's your motivation?
Improve overall system test coverage for .net platforms.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
I have checked that all tests run successfully on my local machine. But I'm not sure if all the tests run successfully on CI.
📋 Checklist:
This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.