Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code-behind feature file compilation speed #336

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Conversation

obligaron
Copy link
Contributor

🤔 What's changed?

When generating a Reqnroll project with many feature files, compilation can be improved (times for BigReqnrollProject with 500 feature files) from 5.4s to 1.1s:

  • original/main 5.4s
  • making FixVB RegEx static 5.2s
  • don't call VBFix in C# project 2.1s
  • cache gherkin dialect (provider) and avoid assembly resource loads 1.2s
  • avoid enum boxing 1.1s

This PR reduces compilation time by 80% (for large projects).

⚡️ What's your motivation?

Trying to improve the compilation time of Reqnroll projects.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

I used the

📋 Checklist:

  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Super! You are great!

Could you please add the PR number to the end of the changelog line?

@obligaron
Copy link
Contributor Author

I added the PR number 🙂

Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@gasparnagy gasparnagy merged commit 4642769 into main Dec 2, 2024
5 checks passed
@gasparnagy gasparnagy deleted the buildspeed branch December 2, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants