Improve parameter type naming for generic types #343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Changed RuntimeBindingType.FullName behavior for generic types.
Before it was simple Type.FullName which is not working good for generic and nullable types.
Now it's using custom logic to provide better value for autocomplete for generic types.
Example new placeholders:
⚡️ What's your motivation?
Current behavior :
List<string>
=> System.Collections.Generic.List`1[[System.String, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]]int?
=> System.Nullable`1[[System.Int32, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]]That is resulting bad autocomplete hints in VS Plugin. (it's using FullName as a Placeholder)
This PR will change autocomplete steps in VS to be more readable.
From placeholder:
[0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]]]
To placeholder:
[List<String>]
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.