Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schedule hooks when enqueuing configured job #792

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

codealchemy
Copy link

Rebased the changes from #681 to update / run CI, closes #679

jweir added 2 commits October 16, 2024 15:40
https://github.com/resque/resque-scheduler#hooks

enqueue_at works as documented, but schedules enqueued from a config have not been calling the before/after schedule hooks.

fixes resque#679
Copy link

@cryptomail cryptomail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there :)
@PatrickTulskie
As if I have any authoritative say in approvals..... haha :) 👿
BUT.... I would like to take this opportunity to thank you for your work on this project.
I was wondering if we could level set expectations on integration of this work, because monkey patching our way out of this is very unsightly and doesn't feel that great :)

Please let me know how I can help.

Again, thanks for your time and attention.

@PatrickTulskie
Copy link
Contributor

Hey there :) @PatrickTulskie As if I have any authoritative say in approvals..... haha :) 👿 BUT.... I would like to take this opportunity to thank you for your work on this project. I was wondering if we could level set expectations on integration of this work, because monkey patching our way out of this is very unsightly and doesn't feel that great :)

Please let me know how I can help.

Again, thanks for your time and attention.

Hey sorry for the looooong delay. Just got back from getting married and I'm trying to get out from under my work backlog. This is high on my list though, so please just bare with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedule hooks do not behave as expected or documented
4 participants