Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: allow overriding 404 handler #127

Merged
merged 1 commit into from
Jan 1, 2020
Merged

feature: allow overriding 404 handler #127

merged 1 commit into from
Jan 1, 2020

Conversation

anuragsoni
Copy link
Collaborator

@anuragsoni anuragsoni commented Dec 31, 2019

Related to #96

@anuragsoni anuragsoni changed the title feat: allow overriding 404 handler feature: allow overriding 404 handler Dec 31, 2019
Copy link
Contributor

@shonfeder shonfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (fwiw 🙂 )

@anuragsoni anuragsoni merged commit fd37bf1 into rgrinberg:master Jan 1, 2020
@anuragsoni anuragsoni deleted the allow-overriding-404-handler branch January 1, 2020 03:52
shonfeder added a commit to shonfeder/opium that referenced this pull request Jan 2, 2020
anuragsoni pushed a commit that referenced this pull request Jan 3, 2020
Link "Lightweight OCaml Webapp Tutorial" from README

Followup to #127
anuragsoni added a commit that referenced this pull request Jan 11, 2020
* Link OCaml Webapp Tutorial from README  (#131)

Link "Lightweight OCaml Webapp Tutorial" from README

Followup to #127

* remove unused dependencies (#132)

* feat: support cohttp lwt_stream body (#135)

* Update stream impl (#137)

* forward headers and code

* First try with httpaf

* add logs + bigstringaf as deps

* run ocamlformat

* Fix opam files

Co-authored-by: Shon Feder <[email protected]>
EduardoRFS pushed a commit to EduardoRFS/opium that referenced this pull request Mar 15, 2020
* Link OCaml Webapp Tutorial from README  (rgrinberg#131)

Link "Lightweight OCaml Webapp Tutorial" from README

Followup to rgrinberg#127

* remove unused dependencies (rgrinberg#132)

* feat: support cohttp lwt_stream body (rgrinberg#135)

* Update stream impl (rgrinberg#137)

* forward headers and code

* First try with httpaf

* add logs + bigstringaf as deps

* run ocamlformat

* Fix opam files

Co-authored-by: Shon Feder <[email protected]>
EduardoRFS pushed a commit to EduardoRFS/opium that referenced this pull request Mar 15, 2020
* Link OCaml Webapp Tutorial from README  (rgrinberg#131)

Link "Lightweight OCaml Webapp Tutorial" from README

Followup to rgrinberg#127

* remove unused dependencies (rgrinberg#132)

* feat: support cohttp lwt_stream body (rgrinberg#135)

* Update stream impl (rgrinberg#137)

* forward headers and code

* First try with httpaf

* add logs + bigstringaf as deps

* run ocamlformat

* Fix opam files

Co-authored-by: Shon Feder <[email protected]>
anuragsoni added a commit to anuragsoni/opam-repository that referenced this pull request Mar 25, 2020
CHANGES:

* Make examples easier to find and add documentation related to features used in them. (rgrinberg/opium#125, @shonfeder)
* Allow overriding 404 handlers (rgrinberg/opium#127, @anuragsoni)
* Support cohttp streaming response (rgrinberg/opium#135, rgrinberg/opium#137, rgrinberg/opium#139, @anuragsoni)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants