-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: allow overriding 404 handler #127
Merged
anuragsoni
merged 1 commit into
rgrinberg:master
from
anuragsoni:allow-overriding-404-handler
Jan 1, 2020
Merged
feature: allow overriding 404 handler #127
anuragsoni
merged 1 commit into
rgrinberg:master
from
anuragsoni:allow-overriding-404-handler
Jan 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuragsoni
changed the title
feat: allow overriding 404 handler
feature: allow overriding 404 handler
Dec 31, 2019
shonfeder
approved these changes
Jan 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (fwiw 🙂 )
shonfeder
added a commit
to shonfeder/opium
that referenced
this pull request
Jan 2, 2020
Followup to rgrinberg#127
anuragsoni
pushed a commit
that referenced
this pull request
Jan 3, 2020
Link "Lightweight OCaml Webapp Tutorial" from README Followup to #127
anuragsoni
added a commit
that referenced
this pull request
Jan 11, 2020
* Link OCaml Webapp Tutorial from README (#131) Link "Lightweight OCaml Webapp Tutorial" from README Followup to #127 * remove unused dependencies (#132) * feat: support cohttp lwt_stream body (#135) * Update stream impl (#137) * forward headers and code * First try with httpaf * add logs + bigstringaf as deps * run ocamlformat * Fix opam files Co-authored-by: Shon Feder <[email protected]>
EduardoRFS
pushed a commit
to EduardoRFS/opium
that referenced
this pull request
Mar 15, 2020
* Link OCaml Webapp Tutorial from README (rgrinberg#131) Link "Lightweight OCaml Webapp Tutorial" from README Followup to rgrinberg#127 * remove unused dependencies (rgrinberg#132) * feat: support cohttp lwt_stream body (rgrinberg#135) * Update stream impl (rgrinberg#137) * forward headers and code * First try with httpaf * add logs + bigstringaf as deps * run ocamlformat * Fix opam files Co-authored-by: Shon Feder <[email protected]>
EduardoRFS
pushed a commit
to EduardoRFS/opium
that referenced
this pull request
Mar 15, 2020
* Link OCaml Webapp Tutorial from README (rgrinberg#131) Link "Lightweight OCaml Webapp Tutorial" from README Followup to rgrinberg#127 * remove unused dependencies (rgrinberg#132) * feat: support cohttp lwt_stream body (rgrinberg#135) * Update stream impl (rgrinberg#137) * forward headers and code * First try with httpaf * add logs + bigstringaf as deps * run ocamlformat * Fix opam files Co-authored-by: Shon Feder <[email protected]>
anuragsoni
added a commit
to anuragsoni/opam-repository
that referenced
this pull request
Mar 25, 2020
CHANGES: * Make examples easier to find and add documentation related to features used in them. (rgrinberg/opium#125, @shonfeder) * Allow overriding 404 handlers (rgrinberg/opium#127, @anuragsoni) * Support cohttp streaming response (rgrinberg/opium#135, rgrinberg/opium#137, rgrinberg/opium#139, @anuragsoni)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #96