Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config to enable short low HP sound #5947

Open
wants to merge 2 commits into
base: upcoming
Choose a base branch
from

Conversation

AsparagusEduardo
Copy link
Collaborator

@AsparagusEduardo AsparagusEduardo commented Jan 3, 2025

Description:

Source for original midi: Team Aqua's Asset Repo.
I adjusted pitch to match base Emerald's

Images

lowhpsound.mp4

Issue(s) that this PR fixes

Closes #1692

Feature(s) this PR does NOT handle:

As charmap.txt cannot be used to toggle, I added a warning to use SE_LOW_HEALTH_SHORT for it.

Discord contact info

AsparagusEduardo

@kittenchilly
Copy link

I checked in both XY and SV, the low health beep actually plays 4 times and not 3. Should probably be changed

@AsparagusEduardo
Copy link
Collaborator Author

I checked in both XY and SV, the low health beep actually plays 4 times and not 3. Should probably be changed

Ah. Thank you, will change.

@AsparagusEduardo
Copy link
Collaborator Author

Done, 4 beeps 👍
(updated video in the description)

@pkmnsnfrn
Copy link
Collaborator

https://discord.com/channels/419213663107416084/774393519569502268/1214616485809496164

Edu, is it within your power level to use a config to control the loop point in the midi itself? I think your current version is totally fine and should be merged, but a config like B_NUM_LOW_HEALTH_BEEPS that just controls how many time the existing one loops would be the better / less invasive version

@khbsd
Copy link

khbsd commented Jan 4, 2025

idk if it helps but i did something similar in case you like the implementation! khbsd@f44c533

@hedara90 hedara90 added the General Doesn't fit under other labels label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Doesn't fit under other labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants