Skip to content

Commit

Permalink
patch for https://phabricator.wikimedia.org/T90492
Browse files Browse the repository at this point in the history 
This allows another file repo for commons.

It requires another patch to Wikibase that is located on gerrit.
  • Loading branch information
@despens
despens committed Feb 25, 2015
1 parent a69ea5a commit 418fcdc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/jquery.ui/jquery.ui.commonssuggester.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
var deferred = $.Deferred();

$.ajax( {
url: location.protocol + '//commons.wikimedia.org/w/api.php',
url: wb.sites.getSiteByGlobalId( wbRepo.commonsSiteId )._siteDetails.apiUrl,

This comment has been minimized.

Sign in to view

Copy link
@filbertkm

filbertkm Feb 25, 2015

although i'm not so knowledgeable about the javascript code base, I am pretty sure this should be an option of the widget, instead of directly depending on wikibase here.

the option might be passed to value view via wikibase.ValueViewBuilder.js (which has access to wb) in WikibaseRepo, though not totally sure how/where/what exactly it would get passed through to here.
dataType: 'jsonp',
data: {
search: term,
Expand Down

0 comments on commit 418fcdc

Please sign in to comment.