Custom Emojis #32
Open
Custom Emojis #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I read through the code in rhysd#31 and @rhysd's comments about what should be returned. I then read through the MDAST nodes and there's an Html node, so I used that for the custom emoji as well as changed the aria accessibility wrapping to use that, making it simpler. Added test cases and tweaked the accessibility ones.
|
@rhysd sorry I let this sit |
|
Hi @rhysd, can you run the workflow? |
|
ping, @rhysd? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I read through the code in #31 and @rhysd's comments about what should be returned. I then read through the MDAST nodes and there's an Html node, so I used that for the custom emoji as well as changed the aria accessibility wrapping to use that, making it simpler.
Added test cases and tweaked the accessibility ones.