-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate name when lowering scf.if
#30
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikhuijzer
changed the title
Fix unique with blocks
Fix duplicate name when lowering Dec 7, 2024
scf.if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where variables are not automatically renamed when lowered from inside the region. This, for example, comes up when lowering
to
Notice that the second definition of
%0
has to be renamed.Now it makes sense why MLIR always renames variables. If you don't, any variable that is inlined and has a name that is the same as another variable needs to have a new name. But say you have
%0
,%1
and now you inline another%0
. What name would you give it?%0_0
? You cannot just call it%2
because, if I'm not mistaken, LLVM will then start to complain (fair enough) because%2
occurs before%1
. Just ignoring names and giving everything a new ("fresh") name leads to much cleaner generated code.