Optimism L1 -> L2 derivation #166
reviewdog [clippy] report
reported by reviewdog 🐶
Findings (1)
primitives/src/batch.rs|39 col 1| error: non-canonical implementation of partial_cmp on an Ord type
--> primitives/src/batch.rs:39:1
|
39 | / impl PartialOrd for Batch {
40 | | fn partial_cmp(&self, other: &Self) -> Option {
| | _____________________________________________________________-
41 | || self.essence.timestamp.partial_cmp(&other.essence.timestamp)
42 | || }
| ||___- help: change this to: { Some(self.cmp(other)) }
43 | | }
| |^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl
= note: -D clippy::non-canonical-partial-ord-impl implied by -D warnings
= help: to override -D warnings add #[allow(clippy::non_canonical_partial_ord_impl)]
Filtered Findings (0)
Annotations
Check failure on line 39 in primitives/src/batch.rs
github-actions / clippy
[clippy] primitives/src/batch.rs#L39
error: non-canonical implementation of `partial_cmp` on an `Ord` type
--> primitives/src/batch.rs:39:1
|
39 | / impl PartialOrd<Self> for Batch {
40 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
| | _____________________________________________________________-
41 | || self.essence.timestamp.partial_cmp(&other.essence.timestamp)
42 | || }
| ||_____- help: change this to: `{ Some(self.cmp(other)) }`
43 | | }
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl
= note: `-D clippy::non-canonical-partial-ord-impl` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::non_canonical_partial_ord_impl)]`Raw output
primitives/src/batch.rs:39:1:e:error: non-canonical implementation of `partial_cmp` on an `Ord` type
--> primitives/src/batch.rs:39:1
|
39 | / impl PartialOrd<Self> for Batch {
40 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
| | _____________________________________________________________-
41 | || self.essence.timestamp.partial_cmp(&other.essence.timestamp)
42 | || }
| ||_____- help: change this to: `{ Some(self.cmp(other)) }`
43 | | }
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl
= note: `-D clippy::non-canonical-partial-ord-impl` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::non_canonical_partial_ord_impl)]`
__END__