-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: alter the schema registry of table with connector #15025
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
601b24a
reject table with conn in alter source
Rossil2012 6d8e5df
alter table with sr
Rossil2012 1ededfd
Merge branch 'main' into kanzhen/alter-table-sr-with-conn
Rossil2012 e43a7ca
reject when datatype changing
Rossil2012 6e1a471
fix error code
Rossil2012 3603a6f
fix e2e test
Rossil2012 767af6a
add unit test
Rossil2012 2f7b5e8
Merge branch 'main' into kanzhen/alter-table-sr-with-conn
Rossil2012 e967670
more comments
Rossil2012 271d4a3
Update src/frontend/src/handler/alter_table_with_sr.rs
Rossil2012 8f9b6ea
use refresh schema syntax
Rossil2012 7e70968
fix tests
Rossil2012 4ddeb81
fix tests
Rossil2012 fffcd4e
fix tests
Rossil2012 a217e46
Merge branch 'main' into kanzhen/alter-table-sr-with-conn
Rossil2012 ed4712f
wait data propagate
Rossil2012 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
20 changes: 20 additions & 0 deletions
20
e2e_test/schema_registry/protobuf/user_with_more_fields.proto
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
syntax = "proto3"; | ||
|
||
package test; | ||
|
||
import "google/protobuf/source_context.proto"; | ||
|
||
message User { | ||
int32 id = 1; | ||
string name = 2; | ||
string address = 3; | ||
string city = 4; | ||
Gender gender = 5; | ||
google.protobuf.SourceContext sc = 6; | ||
int32 age = 7; // new field here | ||
} | ||
|
||
enum Gender { | ||
MALE = 0; | ||
FEMALE = 1; | ||
} |
29 changes: 29 additions & 0 deletions
29
e2e_test/schema_registry/protobuf/user_with_more_fields_pb2.py
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, altering table with same format & encoding but different properties is also supported in this PR, right?
If so, please update the PR description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I reverted the implementation of
ALTER TABLE FORMAT ENCODE
as we discussed in slack that it should be suspended and needs more consideration. This pr is only aboutALTER TABLE REFRESH SCHEMA
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Only
ALTER SOURCE
works,ALTER TABLE ... FORMAT ... ENCODE
is not in this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me summarize. So after this PR gets merged, it will be like
ALTER TABLE <name> FORMAT ... ENCODE ... ( ... )
ALTER SOURCE <name> FORMAT ... ENCODE ... ( ... )
ALTER TABLE <name> REFRESH SCHEMA
ALTER SOURCE <name> REFRESH SCHEMA
Right? Shall we complete the rest two in the future? Asked because I think we should keep the syntax of
create source & table
unified.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right.
ALTER SOURCE <name> REFRESH SCHEMA
is on progress.ALTER TABLE <name> FORMAT ... ENCODE ... ( ... )
will start after further discussion.