Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for background ddl in recovery and certain cases of online scaling #20006

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shanicky
Copy link
Contributor

@shanicky shanicky commented Jan 2, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

I found it somewhat challenging to directly support background jobs in online scaling, so I proposed this PR to add support for background jobs in offline scaling. At the same time, I attempted to skip jobs related to background DDL jobs in online scaling instead of completely omitting them.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@shanicky shanicky force-pushed the peng/dirty-scale-bkgd-ddl branch from 3a43e0b to 3bb430b Compare January 3, 2025 13:34
@shanicky shanicky requested a review from wenym1 January 6, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant