-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): add StreamProjectMaterialize
PlanNode
#8843
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8843 +/- ##
==========================================
- Coverage 70.82% 70.75% -0.07%
==========================================
Files 1172 1173 +1
Lines 194486 194618 +132
==========================================
- Hits 137736 137700 -36
- Misses 56750 56918 +168
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -270,23 +270,8 @@ impl ToStream for LogicalProject { | |||
let new_input = self | |||
.input() | |||
.to_stream_with_dist_required(&input_required, ctx)?; | |||
let new_logical = self.clone_with_input(new_input.clone()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for review: we already do project merge rule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, although there aren't any objections, I think we should mark risingwavelabs/rfcs#24 as accepted first to make sure consensus is reached.
Agreed on waiting, I decided to get the ball rolling as I think the consensus is more or less in this direction - hoping to get it sooner as I'd like this feature for my demo :) |
I agree that this PR can achieve that with minimal invasiveness and easy to revert it... So I think I will be glad to approve it if it is really urgent. But at least, I think we need to add warnings to users "it is an experimental feature" when we write a UDF on an updatable stream. |
Agreed. |
This PR has been open for 60 days with no activity. Could you please update the status? Feel free to ping a reviewer if you are waiting for review. |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add
StreamProjectMaterialize
PlanNodeChecklist For Contributors
./risedev check
(or alias,./risedev c
)Documentation
References
risingwavelabs/rfcs#24