-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stiffness matrix feature to SystemElements class #332
Add stiffness matrix feature to SystemElements class #332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for contributing to the open-source anaStruct project! Your contribution will help thousands of engineers work more efficiently and accuractely.
Now that you've created your first pull request here, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added to anaStruct!
@bldrkamal : This looks great - thanks so much! Your code and PR is well-documented, you added tests, and there's obvious value of what you're adding! Please just fix the linting issues, and I think And I'll see if I can go fix the repo settings here so that I don't have to keep clicking "Approve Workflow Run" on your PR, and it actually auto-runs the tests! |
I really appreciate. I made the necessary changes and I hope it works.
…On Wed, 16 Oct 2024, 10:08 Brooks Smith, ***@***.***> wrote:
@bldrkamal <https://github.com/bldrkamal> : This looks great - thanks so
much! Your code and PR is well-documented, you added tests, and there's
obvious value of what you're adding! Please just fix the linting issues,
and I think mypy is also going to complain at you that you don't have a
type definition on your function. Let me know if you need any help with any
of that!
And I'll see if I can go fix the repo settings here so that I don't have
to keep clicking "Approve Workflow Run" on your PR, and it actually
auto-runs the tests!
—
Reply to this email directly, view it on GitHub
<#332 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHUDVRYOFFDSY7QP5BLSNETZ3YUI5AVCNFSM6AAAAABP3U4JT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJWGE4DKNJTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This pull request introduces a new method, get_stiffness_matrix(), to the SystemElements class. The method allows users to retrieve and print the stiffness matrix of a specific element by its ID.
Key changes:
New Method: get_stiffness_matrix(element_id) in SystemElements.
This method accepts an element_id as input.
It checks if the element exists and is an instance of the Element class.
If the element contains a stiffness matrix, it prints and returns the matrix.
If the element doesn't exist or doesn't have a stiffness matrix, appropriate error messages are printed.
This feature makes it easier to inspect and validate the stiffness matrices of elements within the system, especially useful for debugging and structural analysis. Some students that will like to create their global stiffness matrix will find this useful.