Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Effective C# analyzers and update SquiggleCop baselines #182

Merged
merged 10 commits into from
Aug 26, 2024

Conversation

rjmurillo
Copy link
Owner

@rjmurillo rjmurillo commented Aug 14, 2024

Add Effective C# Analyzers and set all analyzers to Warning for production code

@rjmurillo rjmurillo added this to the v0.2.0 milestone Aug 14, 2024
@rjmurillo rjmurillo self-assigned this Aug 14, 2024
@rjmurillo rjmurillo added dependencies Pull requests that update a dependency file releasable build feature labels Aug 14, 2024
Copy link

codacy-production bot commented Aug 14, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 0bccdf61 93.88% (target: 95.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0bccdf6) Report Missing Report Missing Report Missing
Head commit (af7ebf3) 551 509 92.38%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#182) 49 46 93.88%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@rjmurillo rjmurillo added the analyzers Change that impacts an analyzer behavior label Aug 18, 2024
@@ -0,0 +1,53 @@
using ArgumentOutOfRangeException = System.ArgumentOutOfRangeException;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected tabs found.

Copy link

codeclimate bot commented Aug 26, 2024

Code Climate has analyzed commit af7ebf3 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2
Style 1

View more on Code Climate.

@rjmurillo rjmurillo marked this pull request as ready for review August 26, 2024 17:57
@rjmurillo rjmurillo merged commit e2e6789 into main Aug 26, 2024
6 of 9 checks passed
@rjmurillo rjmurillo deleted the feature/add-effective-csharp-analyzers branch August 26, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzers Change that impacts an analyzer behavior build dependencies Pull requests that update a dependency file feature releasable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant