Update analyzer, refactor code, and add abstract class support #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes several updates and improvements. The `ConstructorArgumentsShouldMatchAnalyzerTests.ShouldFailIfClassParametersDoNotMatch.approved.txt` file has been updated to reflect changes in the source code. The `FooAbstract` class and its usage have been removed from `ConstructorArgumentsShouldMatch.cs`. Defensive programming practices have been added to `DiagnosticVerifier.Helper.cs` to ensure non-null arguments. A new file `AbstractClass.cs` has been added to `Moq.Analyzers.Test.csproj`. The `Analyze` method in `ConstructorArgumentsShouldMatchAnalyzer.cs` has been refactored for better readability and maintainability, and now supports abstract classes. The `Moq.Analyzers.csproj` now uses the latest C# language version and the assembly version has been updated to `0.0.6.0`. New test class `AbstractClassTests` and related files have been added to verify the functionality of the updated analyzer. Fixes #1
|
@MattKotsenas the build action introduced in #9 didn't run on this PR |
Copy/paste error on my part. The default branch is Will update to master until we have the ability to change the default branch. |
|
Actions issue is fixed in #21. |
Updated `AbstractClassTests.ShouldFailIfBadParameters.verified.txt` and `AbstractClassTests.ShouldPassIfGoodParameters.verified.txt` to reflect changes in test conditions. Refactored `AbstractClassTests.cs` to remove `ApprovalTests` namespace, change `ShouldPassIfGoodParameters` to a Task method, and modify `VerifyCSharpDiagnostic` to take an array of file contents. Added `AbstractClass.Bad.cs` for testing incorrect parameters and updated `AbstractClass.Good.cs` with necessary changes. Updated `Moq.Analyzers.Test.csproj` to include new and updated files with `CopyToOutputDirectory` set to `Always`.
Renamed the test method `ShouldPassIfGoodParameters` to `ShouldPassIfGoodParametersAndFailOnTypeMismatch` in `AbstractClassTests`. Removed the diagnostic message for the test `ShouldFailIfBadParameters`. Cleared the content of `AbstractClassTests.ShouldPassIfGoodParameters.verified.txt`. Added a new diagnostic message to `AbstractClassTests.ShouldPassIfGoodParametersAndFailOnTypeMismatch.verified.txt` indicating a `Moq1002` warning for a line in `Test1.cs` where the parameters provided to the `Mock<AbstractClassWithCtor>` constructor do not match any existing constructors.
…arameters.approved.txt This file is no longer needed
|
This is failing between platforms. On Windows and through Ubuntu in WSL, the line numbers are a certain value. On a stand alone Ubuntu VM, they're about 50 chars off. Diagnostic 2
Id: Moq1300
- Location: SourceFile(Test0.cs[1594..1604))
+ Location: SourceFile(Test0.cs[1534..1544))
Highlight: OtherClass
Lines: mock.As<OtherClass>();
Severity: Error
Message: Mock.As() should take interfaces onlyThis is because the exemplar code under test is checked in with CRLF, which is stripped in the Linux environment and causing the span positions to be different on the text run. This was corrected in #33 so we're always EOL LF |
# Conflicts: # Source/Moq.Analyzers.Test/ConstructorArgumentsShouldMatchAnalyzerTests.ShouldFailIfClassParametersDoNotMatch.verified.txt # Source/Moq.Analyzers.Test/Data/ConstructorArgumentsShouldMatch.cs # Source/Moq.Analyzers.Test/Helpers/DiagnosticVerifier.Helper.cs # Source/Moq.Analyzers.Test/Moq.Analyzers.Test.csproj # Source/Moq.Analyzers/ConstructorArgumentsShouldMatchAnalyzer.cs # Source/Moq.Analyzers/Moq.Analyzers.csproj
…into repro-issue-1
MattKotsenas
requested changes
May 31, 2024
| { | ||
| internal class MyBadUnitTests | ||
| { | ||
| private void TestBad() |
There was a problem hiding this comment.
From conversation, some test cases missing:
- Pass an argument to a constructor that takes no arguments
- Pass (string, int) to a constructor that takes (int, string) or equivalent test
- Pass the incorrect number of arguments to constructor
MattKotsenas
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes several updates and improvements.
ConstructorArgumentsShouldMatchAnalyzerTests.ShouldFailIfClassParametersDoNotMatch.approved.txtfile has been updated to reflect changes in the source code.FooAbstractclass and its usage have been removed fromConstructorArgumentsShouldMatch.cs.DiagnosticVerifier.Helper.csto ensure non-null arguments.AbstractClass.cshas been added toMoq.Analyzers.Test.csproj.Analyzemethod inConstructorArgumentsShouldMatchAnalyzer.cshas been refactored for better readability and maintainability, and now supports abstract classes.AbstractClassTestsand related files have been added to verify the functionality of the updated analyzer.Fixes #1