Add reference to Microsoft.CodeAnalysis.AnalyzerUtilities and delete forked methods

[MattKotsenas]

I didn't know that the analyzer utilities in roslyn-analyzers produces a NuGet package. Reference that package and remove our forked copies of code.

[coderabbitai]

📝 Walkthrough

📝 Walkthrough

Walkthrough

This pull request introduces the Microsoft.CodeAnalysis.AnalyzerUtilities package across multiple projects in the solution. The changes involve adding package references to Directory.Packages.props and several project files, including Moq.Analyzers.csproj, Moq.CodeFixes.csproj, and Common.csproj. Additionally, the PR removes some existing classes like BoundedCacheWithFactory, WellKnownTypeProvider, and SymbolVisibility, and makes minor modifications to existing extension classes.

Changes

File	Change Summary
Directory.Packages.props	Added package version for Microsoft.CodeAnalysis.AnalyzerUtilities
src/Analyzers/Moq.Analyzers.csproj src/CodeFixes/Moq.CodeFixes.csproj src/Common/Common.csproj	Added package reference to Microsoft.CodeAnalysis.AnalyzerUtilities with PrivateAssets="all"
src/Common/Caching/BoundedCacheWithFactory.cs	Removed entire class implementation
src/Common/ISymbolExtensions.cs	Removed GetResultantVisibility method
src/Common/ITypeSymbolExtensions.cs	Updated current variable to explicitly nullable ITypeSymbol?
src/Common/SymbolVisibility.cs	Removed entire enum definition
src/Common/WellKnown/KnownSymbols.cs	Added using Analyzer.Utilities
src/Common/WellKnown/MoqKnownSymbols.cs	Added using Analyzer.Utilities
src/Common/WellKnown/WellKnownTypeProvider.cs	Removed entire class implementation
src/Analyzers/SquiggleCop.Baseline.yaml	Updated rule configuration: ECS1200 is now disabled by default
src/CodeFixes/SquiggleCop.Baseline.yaml	Updated rule suppression status for ECS1200 and MA0051

Possibly related PRs

• Update SDK to get newer version of Source Link #202: Adds package reference for Microsoft.CodeAnalysis.AnalyzerUtilities in Moq.Analyzers.csproj
• Refactor to support RS1038 #216: Modifies Directory.Packages.props to update package versions
• Add BannedApiAnalyzer and ban direct use of Diagnostic.Create #239: Introduces BannedApiAnalyzer for diagnostic handling
• Add *.props and *.targets to XML section of .editorconfig template #240: Updates .editorconfig to include .props and .targets files
• Reduce severity of S3267: Loops should be simplified with "LINQ" expressions #272: Modifies severity of diagnostic rule S3267
• Bump GetPackFromProject to fix race in .NET 9 SDK #274: Updates the GetPackFromProject package version

Suggested labels

housekeeping

Suggested reviewers

• rjmurillo

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codeclimate]

Code Climate has analyzed commit 561d437 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Style	1

View more on Code Climate.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6653d6d and 561d437.

📒 Files selected for processing (2)

• tests/Moq.Analyzers.Benchmarks/Moq.Analyzers.Benchmarks.csproj (1 hunks)
• tests/Moq.Analyzers.Test/Moq.Analyzers.Test.csproj (1 hunks)

🔇 Additional comments (1)

tests/Moq.Analyzers.Benchmarks/Moq.Analyzers.Benchmarks.csproj (1)

14-14: LGTM! Verify version consistency across projects.

The package reference addition is appropriate for the benchmark project.

Let's verify the version consistency across all projects:

✅ Verification successful

Version consistency verified across projects

All projects reference Microsoft.CodeAnalysis.AnalyzerUtilities without explicit versions, correctly inheriting version 3.11.0-beta1.24527.2 from Directory.Packages.props. The package reference patterns are also appropriate:

• Source projects (Common, Analyzers, CodeFixes) use PrivateAssets="all"
• Test projects (Test, Benchmarks) use default assets as needed

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for consistent package references across projects
# Expect: All projects should reference the same version from Directory.Packages.props

# Check Directory.Packages.props for version
echo "Package version in Directory.Packages.props:"
rg -A 1 "Microsoft\.CodeAnalysis\.AnalyzerUtilities" Directory.Packages.props

# Check all project files for any explicit versions
echo -e "\nChecking project files for explicit versions:"
fd -e csproj . | xargs rg "Microsoft\.CodeAnalysis\.AnalyzerUtilities"

Length of output: 1179