Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .nupkg baseline with Verify #30

Merged

Conversation

MattKotsenas
Copy link
Collaborator

Add a test that inspects the .nupkg created as part of the build (via <GeneratePackageOnBuild>) and dumps the manifest and file structure to prevent accidental regressions in the package format.

@MattKotsenas MattKotsenas marked this pull request as draft May 31, 2024 05:42
| |-- dotnet
| | |-- cs
| | | |-- Moq.Analyzers.dll
|-- lib
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an analyzer package and there's no "shipping" code, I don't think the lib/ directory should be in the package. Tracked by #31.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to #8?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, likely. 0.0.8 puts it in both places like this change has. 0.0.9 is missing the analyzer.

So I think #8 will be fixed in the next release either way, and also we should ship the analyzer as a lib.

<tags>moq, mock, test, analyzers</tags>
<repository type="git" commit="****************************************" />
<dependencies>
<group targetFramework=".NETStandard2.0" />
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an analyzer only, there's no shipping code, and hence no dependencies, so I don't think this should be here. Tracked by #31.

<id>Moq.Analyzers</id>
<version>********</version>
<authors>Andrey "Litee" Lipatkin</authors>
<licenseUrl>https://github.com/Litee/moq.analyzers/blob/master/LICENSE</licenseUrl>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should switch from the old <licenseUrl> to the new <licenseExpression>. Tracked by #31.

<copyright>2015-2019 Andrey Lipatkin</copyright>
<tags>moq, mock, test, analyzers</tags>
<repository type="git" commit="****************************************" />
<dependencies>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to mark ourselves as a dev dependency. Tracked in #31.

@rjmurillo rjmurillo added this to the Next Major Release milestone May 31, 2024
@MattKotsenas MattKotsenas force-pushed the refactor/add-package-baseline branch from 6b6081f to 7597833 Compare May 31, 2024 17:44
@MattKotsenas MattKotsenas force-pushed the refactor/add-package-baseline branch from 7597833 to 029b0b9 Compare May 31, 2024 17:52
@MattKotsenas MattKotsenas marked this pull request as ready for review May 31, 2024 17:53
@MattKotsenas MattKotsenas requested a review from rjmurillo May 31, 2024 17:53
@rjmurillo rjmurillo merged commit 1b968bc into rjmurillo:master May 31, 2024
4 checks passed
@MattKotsenas MattKotsenas deleted the refactor/add-package-baseline branch May 31, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants