-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .nupkg baseline with Verify #30
Add .nupkg baseline with Verify #30
Conversation
| |-- dotnet | ||
| | |-- cs | ||
| | | |-- Moq.Analyzers.dll | ||
|-- lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is an analyzer package and there's no "shipping" code, I don't think the lib/
directory should be in the package. Tracked by #31.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to #8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, likely. 0.0.8
puts it in both places like this change has. 0.0.9
is missing the analyzer.
So I think #8 will be fixed in the next release either way, and also we should ship the analyzer as a lib.
<tags>moq, mock, test, analyzers</tags> | ||
<repository type="git" commit="****************************************" /> | ||
<dependencies> | ||
<group targetFramework=".NETStandard2.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is an analyzer only, there's no shipping code, and hence no dependencies, so I don't think this should be here. Tracked by #31.
<id>Moq.Analyzers</id> | ||
<version>********</version> | ||
<authors>Andrey "Litee" Lipatkin</authors> | ||
<licenseUrl>https://github.com/Litee/moq.analyzers/blob/master/LICENSE</licenseUrl> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should switch from the old <licenseUrl>
to the new <licenseExpression>
. Tracked by #31.
<copyright>2015-2019 Andrey Lipatkin</copyright> | ||
<tags>moq, mock, test, analyzers</tags> | ||
<repository type="git" commit="****************************************" /> | ||
<dependencies> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want to mark ourselves as a dev dependency. Tracked in #31.
6b6081f
to
7597833
Compare
7597833
to
029b0b9
Compare
Add a test that inspects the
.nupkg
created as part of the build (via<GeneratePackageOnBuild>
) and dumps the manifest and file structure to prevent accidental regressions in the package format.