-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ST7565 LCD displays #170
base: main
Are you sure you want to change the base?
Conversation
adding support for ST7565 lcd
adding support for ST7565 LCD
adding support for ST7565 LCD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! couple of things; can you
- add your name to
CONTRIBUTING.rst
? - take a look at adding tests?
- find the pdf datasheet and add it to the
doc/tech-spec
directory? - check if the docs needs updating?
let us know if you have any questions. See for example 093e53f for a comprehensive driver addition.
i have done pretty moch evreything in the list ecxept tests wich i do not know how they work (i just use luma.examples) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are also some lint errors: https://github.com/rm-hull/luma.lcd/actions/runs/5447216865/jobs/9913063111?pr=170#step:9:24
removed spme whitespace
i removed the whitespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
./luma/lcd/device.py:492:27: W291 trailing whitespace
./luma/lcd/device.py:493:27: W291 trailing whitespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hannescam requested your review on this pull request.
Please take a look at adding unit tests, this cannot be merged without.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this very very similar to the other st7567 driver but just with different init parameters? Can it not just inherit from the other and override the init method?
I tried that, but some things are off that arent possible to set from the parameters that are documented |
added tests for the st7565 based on the tests for the st7567
i implemented some tests based on the st7567 tests but i cant test it because my raspberry pi broke |
The tests don't require raspberry pi hardware. This is also the reason they can be run in a github actions type of environment. |
i didnt know that but how can i test if they are working and how do they work (i couldnt find any documentation) because when i run them no matter which i got no output |
You can run the tests by installing tox: pip install tox Go to the repository root, and run the tests using tox:
If you want to test against a different version of python, use one of This will download the dependencies and run the tests on your machine. Running the tests works out of the box on linux or mac but not sure about windows. |
No description provided.