Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ST7565 LCD displays #170

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

hannescam
Copy link

No description provided.

hannescam added 3 commits July 3, 2023 14:11
adding support for ST7565 lcd
adding support for ST7565 LCD
adding support for ST7565 LCD
Copy link
Collaborator

@thijstriemstra thijstriemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! couple of things; can you

  • add your name to CONTRIBUTING.rst?
  • take a look at adding tests?
  • find the pdf datasheet and add it to the doc/tech-spec directory?
  • check if the docs needs updating?

let us know if you have any questions. See for example 093e53f for a comprehensive driver addition.

luma/lcd/device.py Outdated Show resolved Hide resolved
@thijstriemstra thijstriemstra changed the title adding support for ST7565 LCD displays Support for ST7565 LCD displays Jul 3, 2023
@hannescam
Copy link
Author

i have done pretty moch evreything in the list ecxept tests wich i do not know how they work (i just use luma.examples)

Copy link
Collaborator

@thijstriemstra thijstriemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed spme whitespace
@hannescam
Copy link
Author

i removed the whitespace

@hannescam hannescam requested a review from thijstriemstra July 5, 2023 10:46
Copy link
Collaborator

@thijstriemstra thijstriemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 ./luma/lcd/device.py:492:27: W291 trailing whitespace
./luma/lcd/device.py:493:27: W291 trailing whitespace

@hannescam hannescam requested a review from thijstriemstra July 6, 2023 12:36
@thijstriemstra thijstriemstra requested a review from rm-hull July 9, 2023 09:49
Copy link
Collaborator

@thijstriemstra thijstriemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hannescam requested your review on this pull request.

Please take a look at adding unit tests, this cannot be merged without.

Copy link
Owner

@rm-hull rm-hull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this very very similar to the other st7567 driver but just with different init parameters? Can it not just inherit from the other and override the init method?

@hannescam
Copy link
Author

hannescam commented Jul 10, 2023

I tried that, but some things are off that arent possible to set from the parameters that are documented
and i will try to implement the tests

added tests for the st7565 based on the tests for the st7567
@hannescam
Copy link
Author

i implemented some tests based on the st7567 tests but i cant test it because my raspberry pi broke

@thijstriemstra
Copy link
Collaborator

thijstriemstra commented Jul 22, 2023

i implemented some tests based on the st7567 tests but i cant test it because my raspberry pi broke

The tests don't require raspberry pi hardware. This is also the reason they can be run in a github actions type of environment.

@hannescam
Copy link
Author

i didnt know that but how can i test if they are working and how do they work (i couldnt find any documentation) because when i run them no matter which i got no output

@thijstriemstra
Copy link
Collaborator

thijstriemstra commented Jul 29, 2023

i didnt know that but how can i test if they are working and how do they work (i couldnt find any documentation) because when i run them no matter which i got no output

You can run the tests by installing tox:

pip install tox

Go to the repository root, and run the tests using tox:

cd luma.lcd
tox -e py310

If you want to test against a different version of python, use one of py37, py38, py39, py310 or py311 instead.

This will download the dependencies and run the tests on your machine. Running the tests works out of the box on linux or mac but not sure about windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants