Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1428 ib critical errors #1429

Merged
merged 3 commits into from
Oct 26, 2024
Merged

Bug 1428 ib critical errors #1429

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
593c755
Amended IB connection method to catch all exceptions, log a critical …
Oct 25, 2024
7b91cb7
running black
Oct 25, 2024
abf2c48
Reverted the change to ib_client.py as it could lead to large volume …
Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions sysbrokers/IB/ib_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,18 @@ def __init__(

# You can pass a client id yourself, or let IB find one

self._init_connection(
ipaddress=ipaddress, port=port, client_id=client_id, account=account
)
try:
self._init_connection(
ipaddress=ipaddress, port=port, client_id=client_id, account=account
)
except Exception as e:
# Log all exceptions generated during connection as critical error.
# Under the default production setup this should send an email.
# Error is reraised as we can't really continue and user intervention is required
self.log.critical(
f"IB connection falied with exception - {e}, connection aborted."
)
raise

def _init_connection(
self, ipaddress: str, port: int, client_id: int, account=arg_not_supplied
Expand Down