Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI workflow to test upstream libmagic versions #48

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

robo9k
Copy link
Owner

@robo9k robo9k commented Oct 8, 2023

This is meant to manually test building against a certain upstream libmagic version.
For debugging it uploads the generated magic.h, libmagic.pc and magic.mgc as an artifact.

It also serves as an example of how to use a specific custom libmagic with pkg-config.

@robo9k robo9k mentioned this pull request Oct 8, 2023
6 tasks
@robo9k robo9k force-pushed the test-upstream-versions branch from 4544085 to a67f92b Compare October 8, 2023 03:01
@robo9k robo9k force-pushed the test-upstream-versions branch from a67f92b to 61e10b2 Compare October 8, 2023 03:04
@robo9k
Copy link
Owner Author

robo9k commented Oct 8, 2023

Despite --all-features enabling v5-40 this tests successful against libmagic 5.39 since the then added MAGIC_PARAM_ENCODING_MAX is not used in any #[test], e.g. neither test_magic_setparam nor test_magic_getparam.

I'm not sure if I want to add tests that test such details, at least for now.

@robo9k robo9k merged commit af5aea7 into main Oct 8, 2023
24 checks passed
@robo9k robo9k deleted the test-upstream-versions branch October 8, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant