Fix issue #754 #1035
Merged
Fix issue #754 #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See this comment (#1034 (comment)) about a question on possible change to the implementation. |
3 tasks
|
Hi @rolson24 👋🏻 ! Thanks a lot for your contribution. This is exactly what we needed. I'm super happy with this update. |
SkalskiP
approved these changes
Mar 25, 2024
This was referenced Mar 25, 2024
|
Hi @SkalskiP I made a silly mistake in this PR with using enumerate to get the index of each track, because I forgot to test the new version. I have submitted another PR that fixes the issue. So sorry about this, I will try to remember to re-test every time before I submit a PR. |
rolson24
added a commit
to rolson24/supervision
that referenced
this pull request
Mar 26, 2024
fix bug from PR roboflow#1035 change update_with_tensors to not return tracks with track_id < 0 reset the track_id counter when initializing a new ByteTrack object
rolson24
added a commit
to rolson24/supervision
that referenced
this pull request
Mar 26, 2024
fix bug from PR roboflow#1035 change update_with_tensors to not return tracks with track_id < 0 reset the track_id counter when initializing a new ByteTrack object update docstring
rolson24
added a commit
to rolson24/supervision
that referenced
this pull request
Mar 26, 2024
fix bug from PR roboflow#1035 change update_with_tensors to not return tracks with track_id < 0 reset the track_id counter when initializing a new ByteTrack object update docstring
4 tasks
rolson24
added a commit
to rolson24/supervision
that referenced
this pull request
Mar 26, 2024
fix tuple unpacking bug in PR roboflow#1035 Fix bug with detections with un-initialized tracker_ids
rolson24
added a commit
to rolson24/supervision
that referenced
this pull request
Mar 26, 2024
fix bug from PR roboflow#1035 change update_with_tensors to not return tracks with track_id < 0 reset the track_id counter when initializing a new ByteTrack object update docstring Fix other bug from PR roboflow#1035
onuralpszr
pushed a commit
that referenced
this pull request
Mar 28, 2024
fix tuple unpacking bug in PR #1035 Fix bug with detections with un-initialized tracker_ids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New version of this PR (#1034) with one commit and requested changes.
This change addresses this issue: (#754)
update_with_detectionsnow returns the original detections that were tracked by ByteTrack with their original bboxes, masks, class_ids, data fields and with updated track_ids. Detections that were not tracked this frame are not included in the returned detections.Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
I have tested this change by running object tracking for both object detection and segmentation in this colab notebook
Any specific deployment considerations
Tracking docs should be updated to reflect that ByteTrack can now do segmentation tracking.
Docs