generated from roboflow/template-python
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐞 updating poetry lock file version and fixing numpy,pandas,maplotlib and python versions compatibility #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Onuralp SEZER <[email protected]>
Signed-off-by: Onuralp SEZER <[email protected]>
onuralpszr
force-pushed
the
fix/poetry/py313
branch
from
November 27, 2024 23:29
3041f0d
to
5f0f90b
Compare
onuralpszr
changed the title
fix: 🐞 add poetry lock file re-generated via poetry 1.8.4
fix: 🐞 updating poetry lock file version and fixing numpy,pandas python3.13 problems
Nov 27, 2024
Signed-off-by: Onuralp SEZER <[email protected]>
…to pyproject.toml Signed-off-by: Onuralp SEZER <[email protected]>
…atibility Signed-off-by: Onuralp SEZER <[email protected]>
onuralpszr
changed the title
fix: 🐞 updating poetry lock file version and fixing numpy,pandas python3.13 problems
fix: 🐞 updating poetry lock file version and fixing numpy,pandas,maplotlib and python versions compatibility
Nov 27, 2024
…compatibility Signed-off-by: Onuralp SEZER <[email protected]>
Signed-off-by: Onuralp SEZER <[email protected]>
@LinasKo I fixed poetry installations for all versions and fixes for matplotlib,pandas too. I also include extra tests into CI such as "import test" and full pytest for each poetry envs. it should be better for good. |
Signed-off-by: Onuralp SEZER <[email protected]>
I've tested it, and I couldn't find anything wrong. As an extra check, I verified that a relaxed-constraint version of inference can be installed and run alongside this.
Test codeimport cv2
import numpy as np
from inference import get_model
import supervision as sv
!wget -O dog.jpeg https://media.roboflow.com/notebooks/examples/dog.jpeg -q
image = cv2.imread("dog.jpeg")
assert image is not None
black_image = np.zeros_like(image)
box_model = get_model("yolov8n-640")
result = box_model.infer(image)[0]
detections = sv.Detections.from_inference(result)
assert len(detections) > 0
result = box_model.infer(black_image)[0]
detections = sv.Detections.from_inference(result)
assert len(detections) == 0
seg_model = get_model("yolov8n-seg-640")
result = seg_model.infer(image)[0]
detections = sv.Detections.from_inference(result)
assert len(detections) > 0
result = seg_model.infer(black_image)[0]
detections = sv.Detections.from_inference(result)
assert len(detections) == 0
kp_model = get_model("yolov8n-pose-640")
result = kp_model.infer(image)[0]
keypoints = sv.KeyPoints.from_inference(result)
assert len(keypoints) > 0
result = kp_model.infer(black_image)[0]
keypoints = sv.KeyPoints.from_inference(result)
assert len(keypoints) == 0 |
LinasKo
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to Fix #1688 and update CI tests for make sure we cover this test cases too