Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ColorAnnotator #634

Closed
wants to merge 5 commits into from
Closed

Add ColorAnnotator #634

wants to merge 5 commits into from

Conversation

capjamesg
Copy link
Collaborator

@capjamesg capjamesg commented Dec 4, 2023

Description

This PR adds the ColorAnnotator class to the supervision annotator suite.

Example:

Screenshot 2023-12-04 at 14 15 22

Type of change

  • New feature (non-breaking change which adds functionality)

How has this change been tested, please provide a testcase or example of how you tested the change?

Use the following Notebook to test the feature:

https://colab.research.google.com/drive/1X6KDQB2mw52JBDBibowU7cREA82bFZxs?usp=sharing

Any specific deployment considerations

N/A

Docs

  • Docs updated? What were the changes:

@capjamesg capjamesg added the api:annotator Annotators label Dec 4, 2023
@capjamesg capjamesg self-assigned this Dec 4, 2023
@capjamesg capjamesg requested a review from SkalskiP December 4, 2023 14:20
@capjamesg capjamesg marked this pull request as ready for review December 4, 2023 14:20
Changed the default color for ColorAnnotator from RGB(0,0,0) to the black color constant. Also improved the clarity of initialisation comment (color used for region painting, not replacing). A wrong variable name 'blur_annotator' is also rectified to 'color_annotator'.
@SkalskiP
Copy link
Collaborator

SkalskiP commented Dec 5, 2023

After some brainstorming, we decided to close this PR as you can already get the same effect with the supervision BoxMaskAnnotator. Just set the opacity to 1. But we'll rename BoxMaskAnnotator to ColorAnnotator as this name seems more accurate. This change will be done in a separate PR.

@SkalskiP SkalskiP closed this Dec 5, 2023
@SkalskiP SkalskiP deleted the add-colorannotator branch January 2, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api:annotator Annotators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants