Update atests with preconfigured webdriver #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to setup Chrome before we execute the tasks so that we can avoid selenium-manager doing at the time of execution and changing the debug log messages.
To avoid having the extra logging for selenium-manager (or at least to control the debug output) we are setting the executable_path or the path to the driver. Trying with the event_firing_webdriver script to see if we see debug output there.
There is apparently a method for setting variables. Basically,
echo "{environment_variable_name}={value}" >> "$GITHUB_ENV"
Trying this out ..
Reference:
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-environment-variable
There were a couple tests when I updated the expiry date to variable based upon today had hard coded expected values. To fix I added another far in the future (from now) date to use for these few tests. This actually might be complicating things too much and instead just stay with anouther cookie and hard code it two years out.
There was some missed chnages to the log. In addition, Chrome now has a limit on length of expiry with cookies. Its maximum length is 400 days, as per, https://developer.chrome.com/blog/cookie-max-age-expires/. As such back off the far future date to one just about a year out. Starting to think the hardcoded expiry is better in that one can immediately see it it verse the calculate some date in the future each time the test is run. Will revisit this in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the driver is preconfigured these will update the tests, noting it resolves all issue under Python 3.7 (now at end of life) but not all within Python 3.9. Working in another branch to update Python versions.