-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Vcc
an input as a new field of SensorsData
; Disable Temperature Estimation
#73
Conversation
cc @Nicogene |
Vcc
an input as a field of SensorsData
Vcc
an input as a new field of SensorsData
9535780
to
e59b8b8
Compare
e59b8b8
to
ea41849
Compare
1aa4764 adds the wrapping angle functionality so that FOC can now guarantee that the input electrical angle is always in the correct range [0, 2 Warning In order to generate the code, I had to enable the configuration option variable-sized signals for all the models. @sgiraz, we can give it a run to the whole PR. |
To do so, we need to enable the codegen option for variable-sized signals
77f20f4
to
1aa4764
Compare
941628b introduces a variant subsystem approach to disable temperature estimation, which is currently unfinished. This could give us some margin on the overall FOC computation time. Note By default, the variant parameter is set such that the temperature estimation is OFF. |
Vcc
an input as a new field of SensorsData
Vcc
an input as a new field of SensorsData
; Disable Temperature Estimation
a3f07fd
to
55ec7f6
Compare
55ec7f6
to
941628b
Compare
7153db7
to
335d969
Compare
Important To use the new variant features, we're required to install the Variant Manager Adds-On. |
Hi @pattacini, PR Tested successfully on FOC duration on
Here are the |
Thanks heaps @sgiraz! |
|
What do you think if we create a wiki page where all necessary adds-on are listed, so those are not used to work with the model could install all necessary stuff? |
Yes, I took note of this request. We still have to complete the (long overdue) task of documenting our journey 😄 |
This PR implements #10.
We can start testing the architectural changes once @sgiraz is done with the low-level handling of the
Vcc
readings1.@marcoaccame already implemented the reading of
Vcc
on the AMCBLDC board.@sgiraz is doing the same on AMC.
Important
Clearly, the glue code now needs to pass
Vcc
as an input. Find below the related references.Note
Prior to this PR,$44$ V as a configuration parameter.
Vcc
was initialized to@mfussi66, once the PR is merged, you'd need to update the new project consistently.
Footnotes
Actually, we could go on straight away and pass Vcc as a static input for the moment. ↩