Add flags for user and group impersonation #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacnboyd
force-pushed
the
impersonate-user-group
branch
from
58f8e74 to
76ef444
Compare
|
goreleaser build check will pass after #108 is merged |
|
@isaacnboyd If you can rebase your PRs I think everything should pass, thanks for the work on this! |
As described in issue #30, some companies require administrators to use kubernetes impersonation. This commit uses familiar flags for impersonation and translates them into the client-go config.
isaacnboyd
force-pushed
the
impersonate-user-group
branch
from
76ef444 to
b10872a
Compare
|
Both PRs have been rebased and have no conflicts with each other. Thanks @robscott for reviews! |
|
Thanks @isaacnboyd! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #30, some companies require administrators to use kubernetes impersonation.
This commit uses familiar flags for impersonation and translates them into the client-go config.
resolves #30
resolves #104