-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite admin/includes/js/admin.js without using jQuery. #75
base: master
Are you sure you want to change the base?
Conversation
This is Some points where you can improve the code are:
This can be written with IIFE as:
|
I will submit the code in a couple of days with the implementation of TypeScript to match it with the latest coding trends and to match the suggestions above. |
Merge head repository master branch
I have rewritten the entire code of
admin/includes/js/admin.js
in VanillaJS without using any library like jQuery. #10There is some portion of the code which I found of no use so I did not write it, let me know if that is still required, as I have doubled checked in the
Settings
page and that is working fine without using this portion of the code as below.