-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Callfunc Completion and Validation #1352
Open
markwpearce
wants to merge
25
commits into
release-1.0.0
Choose a base branch
from
callfunc_completion_and_validation
base: release-1.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re built in types
markwpearce
commented
Nov 25, 2024
markwpearce
commented
Nov 25, 2024
markwpearce
commented
Nov 25, 2024
markwpearce
commented
Nov 25, 2024
markwpearce
commented
Nov 25, 2024
markwpearce
commented
Nov 25, 2024
markwpearce
commented
Nov 25, 2024
markwpearce
commented
Nov 25, 2024
markwpearce
commented
Nov 25, 2024
markwpearce
commented
Nov 25, 2024
markwpearce
commented
Nov 25, 2024
markwpearce
commented
Nov 25, 2024
@TwitchBronBron This is ready for review |
TwitchBronBron
requested changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it seems to be working fairly well. I've added a few comments for some bugs I found. Looking forward to testing it again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives
callFunc
a whole lotta love!@.
where ALL possible callfuncs would appear. This was a result of the parser having an exception on incomplete@.
invocations@.
callfunc invocationsCallfunc
and@.
invocations are used to set types in assignmentscallfunc
and@.
While I was it, I also added validation and return typing for
<component>.createChild()
Additional validation enhancements:
typecast
statements when setting up file segments for revalidationTODO:
roSGNode
To be honest, I think that if we properly re-build the Component type when a member file changes, that would fix both problems.
Also fixes #1309