Fix EINVAL crash

[addison-adler]

Related Issues:

• EINVAL crash on latest nodejs

There's a weird crash with the latest version of NodeJS when running ropm.

Error: spawn EINVAL
    at ChildProcess.spawn (node:internal/child_process:421:11)
    at Object.spawn (node:child_process:760:9)
    at C:\Users\bronley\AppData\Roaming\npm\node_modules\ropm\dist\util.js:24:40
    at new Promise (<anonymous>)
    at Util.spawnAsync (C:\Users\bronley\AppData\Roaming\npm\node_modules\ropm\dist\util.js:23:16)
    at Util.spawnNpmAsync (C:\Users\bronley\AppData\Roaming\npm\node_modules\ropm\dist\util.js:37:21)
    at InstallCommand.npmInstall (C:\Users\bronley\AppData\Roaming\npm\node_modules\ropm\dist\commands\InstallCommand.js:70:27)
    at async InstallCommand.run (C:\Users\bronley\AppData\Roaming\npm\node_modules\ropm\dist\commands\InstallCommand.js:39:13) {
  errno: -4071,
  code: 'EINVAL',
  syscall: 'spawn'
} ```

Adding `shell: true` fixes the crash

[TwitchBronBron]

I THINK I remember seeing this option also pop open an actual shell popup. But there's another option for show: false. Could you check into that and report back?

I'd prefer to hide the popup shell if possible..

[addison-adler]

I THINK I remember seeing this option also pop open an actual shell popup. But there's another option for show: false. Could you check into that and report back?

I'd prefer to hide the popup shell if possible..

There is another option we can add for this: windowsHide
Hide the subprocess console window that would normally be created on Windows systems.

I didn't actually see any popups on my PC (windows), but it doesn't hurt to add

[addison-adler]

... and I have just learned that there are unit tests related to this.. I'll update those 😄

edit: added windowsHide: true and updated the unit test

[TwitchBronBron]

Looks great. Thanks!