Implement ctrlc in place of signal hook on Windows #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seriouscatsoserious
force-pushed
the
serious-branch
branch
from
ec88336 to
70e917d
Compare
|
Many thanks for the contribution! |
romanz
requested changes
Dec 11, 2024
|
Should note that there is no Windows job with --features metrics_process flag because Prometheus doesn't work on Windows and I didn't want to introduce more complexity just for that |
romanz
reviewed
Dec 14, 2024
Cargo.toml
Outdated
| tiny_http = { version = "0.12", optional = true } | ||
|
|
||
| [target.'cfg(windows)'.dependencies] | ||
| ctrlc = "3.2.5" |
There was a problem hiding this comment.
Just from curiosity, why not using 3.4.2 ctrlc?
IIUC it should support our MSRV: https://github.com/Detegr/rust-ctrlc/blob/3.4.2/Cargo.toml#L15
seriouscatsoserious
force-pushed
the
serious-branch
branch
3 times, most recently
from
e7cb794 to
217b475
Compare
|
Since this is a binary project, we should use the latest compatible dependency versions. Updated:
This follows Rust's MSRV policy where MSRV bumps are not considered breaking changes. |
seriouscatsoserious
force-pushed
the
serious-branch
branch
4 times, most recently
from
e7f0abe to
3bede84
Compare
romanz
reviewed
Dec 16, 2024
seriouscatsoserious
force-pushed
the
serious-branch
branch
from
3bede84 to
42b987d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Satisfies #709, utilizing ctrlc in place of signal hook on Windows only.