test: simplify go-test #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subhamkrai
reviewed
Jun 19, 2024
| run: | | ||
| OP_NS_OPT="" | ||
| CLUSTER_NS_OPT="" | ||
| test -n "${{ input.op-ns }}" && OP_NS_OPT="--operator-namespace ${{ input.op-ns }}" |
There was a problem hiding this comment.
Suggested change
| test -n "${{ input.op-ns }}" && OP_NS_OPT="--operator-namespace ${{ input.op-ns }}" | |
| test -n "${{ input.op-ns }}" && OP_NS_OPT="--operator-namespace ${{ input.op-ns }}" |
test -n here is for?
There was a problem hiding this comment.
It's old code. OP_NS_OPT should be set iff input.op-ns isn't rook-ceph. CLUSTER_NS_OPT should also be set iff input.cluster-ns isn't rook-ceph. I'll fix them.
subhamkrai
reviewed
Jun 19, 2024
There was a problem hiding this comment.
also CI is not running please check that also @satoru-takeuchi thanks
satoru-takeuchi
force-pushed
the
test-simplify-go-test
branch
from
f8e8b7b to
6e2b741
Compare
satoru-takeuchi
force-pushed
the
test-simplify-go-test
branch
from
6e2b741 to
d8b362a
Compare
satoru-takeuchi
force-pushed
the
test-simplify-go-test
branch
4 times, most recently
from
7e99e04 to
956e28a
Compare
satoru-takeuchi
force-pushed
the
test-simplify-go-test
branch
12 times, most recently
from
2a40197 to
ca36048
Compare
satoru-takeuchi
force-pushed
the
test-simplify-go-test
branch
2 times, most recently
from
2a841d0 to
5a3891c
Compare
subhamkrai
requested changes
Jul 5, 2024
| run: tests/github-action-helper.sh deploy_rook | ||
|
|
||
| - name: deploy rook cluster in custom namespace | ||
| shell: bash --noprofile --norc -eo pipefail -x {0} | ||
| if: inputs.op-ns != '' || inputs.cluster-ns != '' | ||
| if: inputs.op-ns != 'rook-ceph' || inputs.cluster-ns != 'rook-ceph' |
There was a problem hiding this comment.
Suggested change
| if: inputs.op-ns != 'rook-ceph' || inputs.cluster-ns != 'rook-ceph' | |
| if: inputs.op-ns != '=test-operator' || inputs.cluster-ns != '=test-cluster' |
There was a problem hiding this comment.
You meant if: inputs.op-ns == 'test-operator' || inputs.cluster-ns == 'test-cluster'?
Remove duplicated description between the default configuration and the custom namespace configuration. Signed-off-by: Satoru Takeuchi <[email protected]>
satoru-takeuchi
force-pushed
the
test-simplify-go-test
branch
from
5a3891c to
36b237a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicated description between the default configuration and the custom namespace configuration.
Checklist: