Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csi: add test for rbd ls with rados namespace #342

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

OdedViner
Copy link
Contributor

@OdedViner OdedViner commented Dec 12, 2024

this pr introduces a new test to verify the rbd ls
command functionality when working with rados namespaces.
the test ensures that rbd images are correctly listed

$ ./bin/kubectl-rook-ceph rbd ls
poolName            imageName                                     namespace    
--------            ---------                                     ---------    
blockpool-rados-ns  csi-vol-465d5545-b621-4adb-afd6-fd548dbd0062  namespace-a  
blockpool-rados-ns  ---                                           namespace-b  
replicapool         ---                                           ---  

when namespaces are configured.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@travisn
Copy link
Member

travisn commented Dec 13, 2024

Please add a description to the PR and commit message.

@OdedViner OdedViner changed the title WIP: add rbd namespace test CSI: add rbd namespace test Dec 17, 2024
@OdedViner OdedViner changed the title CSI: add rbd namespace test csi: add test for rbd ls with rados namespace Dec 17, 2024
@OdedViner
Copy link
Contributor Author

Please add a description to the PR and commit message.

@travisn done

@travisn travisn requested a review from subhamkrai December 17, 2024 14:29
Copy link
Collaborator

@subhamkrai subhamkrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OdedViner with this PR you are creating the resources and the test is already in place. Right?

@OdedViner
Copy link
Contributor Author

OdedViner commented Dec 18, 2024

@OdedViner with this PR you are creating the resources and the test is already in place. Right?

@subhamkrai Correct, the test runs rbd ls with the rados namespace, both with and without a storage class.

@OdedViner OdedViner force-pushed the test_rbd branch 2 times, most recently from 085c441 to 75f8322 Compare December 18, 2024 11:15
this pr introduces a new test to verify the  `rbd ls`
command functionality when working with rados namespaces.
the test ensures that rbd images are correctly listed
when namespaces are configured.

Signed-off-by: Oded Viner <[email protected]>
@subhamkrai subhamkrai merged commit f5e8566 into rook:master Dec 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants