pD => pV

ropensci · Sep 6, 2024 · 392fa9a · 392fa9a
1 parent a8493d6
commit 392fa9a
Show file tree

Hide file tree

Showing 11 changed files with 20 additions and 10 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -13,7 +13,7 @@ Description: Bayesian data analysis usually incurs long runtimes
   For the underlying methodology, please refer
   to the documentation of 'targets' <doi:10.21105/joss.02959> and 'JAGS'
   (Plummer 2003) <https://www.r-project.org/conferences/DSC-2003/Proceedings/Plummer.pdf>.
-Version: 1.2.0.9000
+Version: 1.2.1
 License: MIT + file LICENSE
 URL: https://docs.ropensci.org/jagstargets/, https://github.com/ropensci/jagstargets
 BugReports: https://github.com/ropensci/jagstargets/issues
@@ -68,6 +68,6 @@ SystemRequirements: JAGS 4.x.y (https://mcmc-jags.sourceforge.net)
 Encoding: UTF-8
 Language: en-US
 Roxygen: list(markdown = TRUE)
-RoxygenNote: 7.3.1
+RoxygenNote: 7.3.2
 VignetteBuilder: knitr
 Config/testthat/edition: 3
diff --git a/NEWS.md b/NEWS.md
@@ -1,6 +1,6 @@
-# jagstargets 1.2.0.9000 (development)
-
+# jagstargets 1.2.1
 
+* Return `pV` instead of `pD` in DIC info (#35).
 
 # jagstargets 1.2.0
 

diff --git a/R/tar_jags_df.R b/R/tar_jags_df.R
@@ -12,7 +12,7 @@
 #'   to return: `"draws"` for MCMC samples (which could take up a lot of space)
 #'   `"summary"` for lightweight posterior summary statistics,
 #'   and `"dic"` for the overall deviance information criterion
-#'   and effective number of parameters
+#'   and effective number of parameters.
 #' @param summaries List of summary functions passed to `...` in
 #'   `posterior::summarize_draws()` through `$summary()`
 #'   on the `CmdStanFit` object.
@@ -115,6 +115,6 @@ join_data_scalar <- function(text, data) {
 tar_jags_df_dic <- function(fit) {
   tibble::tibble(
     dic = fit$BUGSoutput$DIC,
-    pD = fit$BUGSoutput$pD
+    pV = fit$BUGSoutput$pV
   )
 }
diff --git a/man/tar_jags.Rd b/man/tar_jags.Rd
diff --git a/man/tar_jags_df.Rd b/man/tar_jags_df.Rd
diff --git a/man/tar_jags_rep.Rd b/man/tar_jags_rep.Rd
diff --git a/man/tar_jags_rep_dic.Rd b/man/tar_jags_rep_dic.Rd
diff --git a/man/tar_jags_rep_draws.Rd b/man/tar_jags_rep_draws.Rd
diff --git a/man/tar_jags_rep_run.Rd b/man/tar_jags_rep_run.Rd
diff --git a/man/tar_jags_rep_summary.Rd b/man/tar_jags_rep_summary.Rd
diff --git a/tests/testthat/test-tar_jags_df.R b/tests/testthat/test-tar_jags_df.R
@@ -80,7 +80,7 @@ targets::tar_test("tar_jags_df() with dic", {
   # dic
   dic <- tar_jags_df(out, data = data, "dic")
   expect_equal(nrow(dic), 1)
-  expect_equal(sort(colnames(dic)), sort(c("dic", "pD")))
+  expect_true("dic" %in% colnames(dic))
   # invalid output
   expect_error(tar_jags_df(out, "nope"))
 })