Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolve IP feature #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

snovvcrash
Copy link

Hi @ropnop!

In this PR I would like to bring a fix for the --resolve switch. Currently using the resolve IP feature breaks the script due to a type error:

$ python3 windapsearch.py --dc-ip 127.0.0.1 -d corp.local -u '' -C -r > windapsearch.out
Traceback (most recent call last):
  File "/home/snovvcrash/tools/windapsearch/windapsearch.py", line 825, in <module>
    run(args)
  File "/home/snovvcrash/tools/windapsearch/windapsearch.py", line 610, in run
    allComputersDict = ldapSession.getComputerDict(allComputers, ipLookup=True)
  File "/home/snovvcrash/tools/windapsearch/windapsearch.py", line 380, in getComputerDict
    computerInfo[attr] = ','.join(computer.get_attr_values(attr))
TypeError: sequence item 0: expected str instance, bytes found

The ipLookup argument in getComputerDict does not seem to be used as well, but I left it as is.

Also I've added a cyrillic name for Domain Admins group in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant