Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset node on initialization #334

Open
wants to merge 1 commit into
base: melodic-devel
Choose a base branch
from

Conversation

jschleicher
Copy link

Resetting the communication only loads default values for the pdo mapping in the motor firmware according to CiA 301. I suggest with this PR to also reset the application registers to get a roslaunch behaviour that is similar to a power-on-reset of the motor (firmware) to fully recover from errors and values from the previous run.

What do you think?

Resetting the communication only loads default values for the pdo mapping in the motor firmware according to CiA 301. Also reset the application registers to get a roslaunch behaviour that is similar to a power-on-reset of the motor to recover from errors and values from the previous run.
@mathias-luedtke
Copy link
Member

mathias-luedtke commented Jun 11, 2019

In general: 👍
Unfortunately, some devices are not compatible with this change.
E.g., Elmo devices seem to connect the CAN lines to ground during reset(), which breaks the CAN communication in a chain.

I am afraid, we have to make this somehow configurable.

@mathias-luedtke
Copy link
Member

I am afraid, we have to make this somehow configurable.

What do you think of a deep_reset argument in an additional constructor (ABI..) that gets passed down from canopen_chain_node?

@jschleicher
Copy link
Author

Sounds good. Probably this is better than an additional /reset service that the user can trigger in addtion before the /init service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants