Cannot launch when there's a [space] to the ros_ws path #17
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is a [space] in the path to the `ros_ws`, the xacro command will throw an error. Signed-off-by: dominik potulski <[email protected]>
SteveMacenski
requested changes
Dec 16, 2024
There was a problem hiding this comment.
I don't disagree that this would fix that issue, however there are numerous locations where we get paths to files and directories. I think we should aim to solve that for all instances of os.path.join that are user-configurable so that you don't just run into this problem next file you change as well :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a [space] in the path to the
ros_ws, the xacro command will throw an error.This is fixed with this commit.