-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cross-platform CI with conda packages #1600
base: noetic-devel
Are you sure you want to change the base?
Conversation
resolution 96 | ||
} | ||
|
||
# Ogre >= 1.10 has changed the format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I think it's actually Ogre > 1.10 that has changed format, not >= 1.10. As we use Ogre 1.10 in RoboStack, this causes issues. But to be confirmed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you end up with 1.10? You could solve this by updating to 1.12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does rviz work with 1.12? If yes, we could totally attempt a build!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noetic-devel
does, yes, I tried getting it set as the default for noetic actually but gazebo had already released their last ever release and have some issues with it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we also have gazebo on conda forge and it would be better if rviz and gazebo are side by side installable, so it's the same problem. We could build a variant with updated ogre though
@@ -34,6 +34,7 @@ | |||
#include <OgreRectangle2D.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove the changes that are from #1532 and discuss them there instead.
The cross-platform CI in action can be seen here |
This pull request has been mentioned on ROS Discourse. There might be relevant details there: |
Description
Hi, the intent of this PR is twofold:
I (myself) have to go through the patches that we added and figure out how we can upstream them (and I will note that in it's current state they are not ready to be upstreamed -- that's why this is a draft PR).
Checklist
YAML
orrosbag
file with aMarkerArray
msg.Due to the lack of active maintainers, we cannot provide support for older release branches anymore.