Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes #98

Open
wants to merge 5 commits into
base: melodic-devel
Choose a base branch
from
Open

Various fixes #98

wants to merge 5 commits into from

Conversation

eric-wieser
Copy link
Contributor

@eric-wieser eric-wieser commented Jan 10, 2018 •
edited
Loading

I can split these up if any are objectionable

Last commit is the most valuable - it allows quotes in default values, descriptions, and enum info

@eric-wieser
Copy link
Contributor Author

Looks like I forgot to update the unit tests with the quoted values

@mikaelarguedas
Copy link
Member

Thanks @eric-wieser for the patch and the patience.
I'd like to split the syntax improvements (use with statements, new-style classes) from the feature extension. I will open a PR with a subset of these commits if that's fine with you.
If you get a chance to update the tests to match the descriptions modified in this PR, it would be much appreciated

@mikaelarguedas mikaelarguedas mentioned this pull request Apr 3, 2018
Merged
@mikaelarguedas mikaelarguedas mentioned this pull request Sep 18, 2018
Merged
@mikaelarguedas mikaelarguedas changed the base branch from master to melodic-devel October 2, 2018 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eric-wieser @mikaelarguedas